Add plugin: obsidian-ivre-plugin

[p-l-]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/ivre/obsidian-ivre-plugin

Release Checklist

• I have tested the plugin on
  • Windows
  • macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
• My GitHub release contains all required files
  • main.js
  • manifest.json
  • styles.css (optional)
• GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• The id in my manifest.json matches the id in the community-plugins.json file.
• My README.md describes the plugin's purpose and provides clear usage instructions.
• I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
• I have added a license in the LICENSE file.
• My project respects and is compatible with the original license of any code from other plugins that I'm using.
  I have given proper attribution to these other projects in my README.md.

[liamcain]

• this.app this is not defined. It might be working but it's falling back to the global scope, which I don't think you should be relying on. It's currently accessible from the global context for debugging purposes, and might be removed in the future. Instead, you should use the reference to App that you have from your plugin instance and just pass that into your functions.
• this.app same thing
• this.app here too
• this.app.vault and here
• this.app. hmm, okay there's a lot of them. I won't point them all out
• getActiveFile this can return null. Also, since you're passing in a MarkdownView to this function, you should be comparing it to the view.file and not the active file
• ivre you don't need to prefix the ID with your plugin name, it will get automatically prefixed with it by the addCommand

[github-actions]

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ There's no need to include obsidian in the plugin ID. The ID is used for your plugin's settings folder so it should closely match your plugin name for user convenience.

---

^{This check was done automatically.}

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin ID mismatch, the ID in this PR is not the same as the one in your repo.

---

Warnings:

⚠️ There's no need to include obsidian in the plugin ID. The ID is used for your plugin's settings folder so it should closely match your plugin name for user convenience.

---

^{This check was done automatically.}

[github-actions]

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ There's no need to include obsidian in the plugin ID. The ID is used for your plugin's settings folder so it should closely match your plugin name for user convenience.

---

^{This check was done automatically.}

[p-l-]

@liamcain thanks a lot for your review! Sorry for all the mistakes, I'm a total noob in both TypeScript and the Obsidian API!

Hope it's better now, let me know if there are other things to fix. Release 1.2.0 contains your proposed fixes.

[liamcain]

• this.app.workspace.getActiveFile sorry, I might not have been clear here. I was suggesting you don't call getActiveFile. While under normal circumstances, it would be the same as the file in the MarkdownView, you don't really want to make that assumption. So I would change this line to be view.file (you have access to file from the FileView (https://github.com/obsidianmd/obsidian-api/blob/38dd22168d2925086371bfc59e36fd9121527a39/obsidian.d.ts#L1372)
• this.app.workspace.getActiveFile same here.

[p-l-]

Thanks again @liamcain! That's done. Do you see something else that should be done?

[liamcain]

LGTM, merged!

[p-l-]

Thanks!