Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced table extension plugin #2281

Merged
merged 7 commits into from
Sep 11, 2023
Merged

Conversation

NicoNekoru
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/NicoNekoru/obsidan-advanced-table-xt

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ] in JSON at position 255643


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ] in JSON at position 255641


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word obsidian in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
❌ Please don't use the word Obsidian at the start of your plugin name since it's redundant and makes it harder to sort the plugin list.
❌ The fundingUrl field in your manifest should not point to the Obsidian Website, If you don't have a link were users can donate to you, you can just omit this.


Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The fundingUrl field in your manifest should not point to the Obsidian Website, If you don't have a link were users can donate to you, you can just omit this.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@NicoNekoru NicoNekoru changed the title Update community-plugins.json Add advanced table extension plugin Aug 11, 2023
@joethei
Copy link
Collaborator

joethei commented Aug 16, 2023

compatability
Typo

MarkdownPreviewRenderer.registerPostProcessor(async (el, ctx) =>
Use this.registerMarkdownPostProcessor instead, this will make sure it's properly unloaded when you plugin is unloaded.

console.log('spreadsheets loaded');
Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

@joethei joethei self-assigned this Aug 16, 2023
NicoNekoru added a commit to NicoNekoru/obsidan-advanced-table-xt that referenced this pull request Aug 18, 2023
@NicoNekoru
Copy link
Contributor Author

Fixed the requested changes

@NicoNekoru
Copy link
Contributor Author

@liamcain @joethei Any updates?

@liamcain liamcain merged commit 7081c33 into obsidianmd:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants