Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Dataview Publisher #3674

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Add plugin: Dataview Publisher #3674

merged 2 commits into from
Jul 1, 2024

Conversation

udus122
Copy link
Contributor

@udus122 udus122 commented Jun 10, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/udus122/dataview-publisher

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add Dataview Publisher plugin Add plugin: Dataview Publisher Jun 10, 2024
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Jun 12, 2024

"description": "Output markdown from your Dataview queries and keep them up to date. You can also be able to publish them.",
The second sentence is grammatically wrong.

const activeLeaf = this.app.workspace.getActiveViewOfType(MarkdownView);
To get the active editor use this.app.workspace.activeEditor?.editor, which will mean that this code works in Canvas.

throw new Error("Dataview API not found");
This should also be shown to the user, not everyone knows of the dev console.

id: "dataview-publisher-insert-block",, id: "dataview-publisher-update-blocks",, id: "dataview-publisher-update-blocks-and-publish",
Don't prefix the command id with the plugin id, Obsidian will make sure that there are no conflicts with other plugins.
Also the command names could be shorter.

@udus122
Copy link
Contributor Author

udus122 commented Jun 13, 2024

@joethei Thanks for your review.

We have fixed all of your change requests and released it.
udus122/dataview-publisher#18

Please review again.

P.S. I realized that I forgot to change the description in community-plugins.json, so I fixed it.

@joethei joethei added Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jun 28, 2024
@joethei joethei merged commit 9f38cef into obsidianmd:master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants