Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: AutoPause #4195

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add plugin: AutoPause #4195

merged 1 commit into from
Sep 24, 2024

Conversation

ckep1
Copy link
Contributor

@ckep1 ckep1 commented Sep 10, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/ckep1/obsidian-AutoPause

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Update community-plugins.json Add plugin: AutoPause Sep 10, 2024
@ckep1
Copy link
Contributor Author

ckep1 commented Sep 10, 2024

Accidentally deleted this pull request initially: #4177

No changes from that.

@ckep1
Copy link
Contributor Author

ckep1 commented Sep 10, 2024

styles.css is checked off as it is not required for this project and therefore not included.

@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Sep 23, 2024

evt.target as HTMLAudioElement;
Remove this cast, it's confusing as you are doing the approriate instanceof in the line after.

@joethei joethei merged commit 937d9e1 into obsidianmd:master Sep 24, 2024
1 check passed
@ckep1
Copy link
Contributor Author

ckep1 commented Sep 24, 2024

Made requested change in repository, published version 1.0.1.

Thanks!

@ckep1 ckep1 deleted the patch-1 branch September 24, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants