Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scroll-speed plugin #910

Merged
merged 3 commits into from
Jun 23, 2022
Merged

add scroll-speed plugin #910

merged 3 commits into from
Jun 23, 2022

Conversation

flolu
Copy link
Contributor

@flolu flolu commented Apr 20, 2022

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/flolu/obsidian-scroll-speed

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@lishid
Copy link
Collaborator

lishid commented Apr 26, 2022

https://github.com/flolu/obsidian-scroll-speed/blob/89d248642429993eb673543f9de15b21604d36a2/main.ts#L25
You are not un-registering this properly because .bind() creates a new function. What you can do here is to set scrollListener to a bound function like this:

scrollListener = (event: AugmentedWheelEvent) => {
  ...
}

Then you can simply remove the .bind(this).

https://github.com/flolu/obsidian-scroll-speed/blob/89d248642429993eb673543f9de15b21604d36a2/main.ts#L45
You may want to use this instead: https://stackoverflow.com/a/39245638

@flolu
Copy link
Contributor Author

flolu commented Jun 12, 2022

@lishid I have fixed the issues in the latest release.

@github-actions
Copy link

Hello flolu!

I found the following errors in your plugin, Scroll Speed:

❌ Unable to find a release with the tag "1.0.2". Make sure that the manifest.json file in your repo points to the correct Github Release

Log
HttpError: Not Found

This check was done automatically.

@liamcain
Copy link
Collaborator

Hi @flolu, it looks like your git tag is misnamed. In your latest release, the git tag is v1.0.2. You should remove the v

image

Ping me once you update the tag name so I can merge this, thanks!

@flolu
Copy link
Contributor Author

flolu commented Jun 23, 2022

Hi @liamcain. I just removed the v from the tag name

@liamcain liamcain merged commit ef0151c into obsidianmd:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants