Add some changes from Dune #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same things apply for ledger-app-tezos. Taken from https://gitlab.com/dune-network/ledger-app-dune/blob/master/docs/MEMORY_TIPS.md Co-authored-by: Alain Mebsout <alain.mebsout@origin-labs.com>
3noch
reviewed
Nov 5, 2019
src/main.c
Outdated
| @@ -16,9 +16,9 @@ void app_main(void) { | |||
| global.handlers[APDU_INS(INS_VERSION)] = handle_apdu_version; | |||
| global.handlers[APDU_INS(INS_GET_PUBLIC_KEY)] = handle_apdu_get_public_key; | |||
| global.handlers[APDU_INS(INS_PROMPT_PUBLIC_KEY)] = handle_apdu_get_public_key; | |||
| global.handlers[APDU_INS(INS_SIGN)] = handle_apdu_sign; | |||
| global.handlers[APDU_INS(INS_SIGN)] = handle_apdu; | |||
There was a problem hiding this comment.
Maybe handle_apdu_sign would be better name? This name doesn't specify what kind of APDU instruction it handles.
There was a problem hiding this comment.
yeah that would be better
This is a more clear name than just handle_apdu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ledger-app-dune has some changes on to the app that we are able to incorporate. This adds some changes.
Repo URL is https://gitlab.com/dune-network/ledger-app-dune