Prevent uninitialized StorePath creation

obsidiansystems · Feb 13, 2020 · d897231 · d897231
1 parent 94c9343
commit d897231
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/libstore/path.hh b/src/libstore/path.hh
@@ -18,6 +18,8 @@ extern "C" {
 
 struct StorePath : rust::Value<3 * sizeof(void *) + 24, ffi_StorePath_drop>
 {
+    StorePath() = delete;
+
     static StorePath make(std::string_view path, std::string_view storeDir);
 
     static StorePath make(unsigned char hash[20], std::string_view name);

diff --git a/src/libutil/rust-ffi.hh b/src/libutil/rust-ffi.hh
@@ -113,6 +113,8 @@ extern "C" {
 
 struct String : Vec<char, ffi_String_drop>
 {
+    String() = delete;
+
     String(std::string_view s)
     {
         ffi_String_new(StringSlice(s), this);

diff --git a/src/nix/why-depends.cc b/src/nix/why-depends.cc
@@ -103,7 +103,7 @@ struct CmdWhyDepends : SourceExprCommand
         std::map<StorePath, Node> graph;
 
         for (auto & path : closure)
-            graph.emplace(path.clone(), Node{path.clone(), cloneStorePathSet(store->queryPathInfo(path)->references)});
+            graph.emplace(path.clone(), Node { .path = path.clone(), .refs = cloneStorePathSet(store->queryPathInfo(path)->references) });
 
         // Transpose the graph.
         for (auto & node : graph)
@@ -112,7 +112,7 @@ struct CmdWhyDepends : SourceExprCommand
 
         /* Run Dijkstra's shortest path algorithm to get the distance
            of every path in the closure to 'dependency'. */
-        graph[dependencyPath.clone()].dist = 0;
+        graph.emplace(dependencyPath.clone(), Node { .path = dependencyPath.clone(), .dist = 0 });
 
         std::priority_queue<Node *> queue;