Support substituting in fetchGit #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builtins.fetch* aren’t technically derivations, so they never got substituted. To work around this, we can try to substitute this store path during evaluation. This can happen any time a hash is provided. Updated to be closer to how the flakes branch works.
matthewbauer
force-pushed
the
ipfs-git-ipld
branch
from
8e99d98
to
5fa33d7
Compare
This is disabled automatically when we’re offline.
matthewbauer
force-pushed
the
ipfs-git-ipld
branch
from
dcedb93
to
4074142
Compare
matthewbauer
commented
Jun 23, 2020
| @@ -134,6 +134,20 @@ static void fetch(EvalState & state, const Pos & pos, Value * * args, Value & v, | |||
| if (evalSettings.pureEval && !expectedHash) | |||
| throw Error("in pure evaluation mode, '%s' requires a 'sha256' argument", who); | |||
|
|
|||
| // try to substitute if we can | |||
There was a problem hiding this comment.
this isn't actually necessary, but eventually we may want to support fetchGit
Ericson2314
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports using fetchGit with substitutions.