Systematize ipfs-git parsing a bit #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
changed the title
matthewbauer
reviewed
Jul 9, 2020
| FixedOutputInfo, | ||
| IPFSInfo, | ||
| IPFSHash | ||
| > ContentAddressWithoutName; |
There was a problem hiding this comment.
we should get a better name for this
There was a problem hiding this comment.
Naming for these could be:
- ContentAddress becomes StorePathDescriptor
- ContentAddressWithoutName becomes ContentAddressWithReferences
- LegacyContentAddress becomes ContentAddress
There was a problem hiding this comment.
I like StorePathDescriptor
matthewbauer
reviewed
Jul 9, 2020
matthewbauer
reviewed
Jul 9, 2020
Ericson2314
force-pushed
the
git-ipfs-refs-parser-changes
branch
from
74029af
to
11b4343
Compare
Ericson2314
force-pushed
the
git-ipfs-refs-parser-changes
branch
from
11b4343
to
0aff60d
Compare
Ericson2314
changed the title
matthewbauer
approved these changes
Jul 10, 2020
| std::string_view tag; | ||
| { | ||
| auto optName = splitPrefixTo(rest, ':'); | ||
| auto optTag = splitPrefixTo(rest, ':'); |
There was a problem hiding this comment.
I would expect tag to before anything else
There was a problem hiding this comment.
Well I wanted to keep the name and ca-with-refs separate. I like your idea of making it separate args, eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaled back version of #58.