Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Nix store path from source maps #1084

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove Nix store path from source maps #1084

wants to merge 1 commit into from

Commits on Jun 5, 2024

  1. Remove Nix store path from source maps 

    Obelisk successfully serves minified JS, the corresponding unminified JS,
and the source map that relates the two. But the source map's `sources`
field contains the Nix store path of the unminified JS, not a URL. Browsers
try to fetch the source code from a bogus URL:
`https://example.com/nix/store/HASH-compressedJs/frontend.jsexe/all.unminified.js`.

This change improves the situation by tweaking the arguments to
`closure-compiler`; using relative paths to the JS files instead of absolute
paths.

Works on Chromium, but Firefox still has trouble.
    @isaac-uptrust
    isaac-uptrust committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e5c61ed View commit details
    Browse the repository at this point in the history