Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward compatibility with iproute deprecation #1104

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

alexfmpe
Copy link
Contributor

Using obelisk libs against a newer nixpkgs causes

error: 'iproute' has been renamed to/replaced by 'iproute2'

Change seems safe enough since I get this at the root repo

$ git rev-parse HEAD
dcff475503cca5cdc026642e779eae6de4c36528

$ nix-build -A nixpkgs.iproute
/nix/store/03q9fjs925aznfmlm476hpkdjbcvky6z-iproute2-5.19.0

$ nix-build -A nixpkgs.iproute2
/nix/store/03q9fjs925aznfmlm476hpkdjbcvky6z-iproute2-5.19.0

I have:

  • Based work on latest develop branch
  • Followed the contribution guide
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • Updated the changelog
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

@alexfmpe alexfmpe marked this pull request as draft November 22, 2024 18:31
@alexfmpe alexfmpe marked this pull request as ready for review November 22, 2024 18:59
@alexfmpe
Copy link
Contributor Author

Taking effect also requires reflex-frp/reflex-platform#841

Copy link
Contributor

@maralorn maralorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maralorn
Copy link
Contributor

Huh, I don’t have merge rights. I feel like I should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants