-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend-tools: Avoid initializing the scene switcher on Wayland #10877
frontend-tools: Avoid initializing the scene switcher on Wayland #10877
Conversation
The Linux implementation of the automatic scene switcher is X11-only and the design itself of the feature is incompatible with how Wayland works.
For posterity, is this possible to fix on Wayland, or is there a fundamental missing functionality that prevents this from ever working? I understand disabling it fixes an immediate problem/crash, and a solution might take longer, but it's not clear if this is something that can be fixed or not. If we're disabling features, I'd like to at least have an issue open (or discussion post) on what steps are required to re-enable it back to feature parity, if possible. High-level is fine, it does not need to be an exact technical roadmap. |
Under Wayland, application can't be aware of other application windows for multiple reason (e.g. security, avoid re-inventing X11). This feature will never be possible on Wayland. |
I don't quite agree with "never be possible" here, but it sounds like if Wayland offers a secure API at some point to provide window information, we can revisit this. As it stands, Wayland doesn't provide the information that this features needs to function, so I'm fine disabling it there. |
This kind of interaction (listing other windows and accessing their state) isn't available in any existing Wayland protocols, and I think this is by design. Given the security requirements, this looks like something that should be provided by a portal. Right now nothing exists in the Wayland / Portals platform that can enable this feature, so I think disabling it for the time being is all that OBS can do. |
Just to confirm, this happens on 30.1.x and older, correct? |
Yes, it happens in all current and previous releases of OBS Studio. |
Okay then. Based on that information, I'll set this aside until we get into the merge window for the next release. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The Linux implementation of the automatic scene switcher is X11-only and the design itself of the feature is incompatible with how Wayland works.
Motivation and Context
If a user happen to have the scene switcher active, OBS will crash while freeing the tool under Wayland.
The saved configuration should be kept since we no longer create the scene collection JSON from scratch, so there is normally no loss.
How Has This Been Tested?
The scene switcher is no longer loaded on Wayland.
Types of changes
Checklist: