Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs: Also determine WinUI 3 Window #10920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qhy040404
Copy link

@qhy040404 qhy040404 commented Jun 26, 2024

Description

Besides UWP applications, which means WinUI 2 applications that cannot be captured by BitBlt, WinUI 3 applications also cannot be captured by BitBlt. This commit adds a check for WinUI 3 applications.
4b2dbc9b1739085bfae80554fdf1a693

Motivation and Context

Just as we cannot use Bitblt to capture the screen of UWP (WinUI 2) applications, WinUI 3 applications also have this problem. However, we have not made any special judgment on WinUI 3 at present.

How Has This Been Tested?

  • Install WinUI 3 Gallery and WinUI 2 Gallery, which is, WinUI 3 applications and UWP (WinUI 2) applications.
  • Use Window Capture to capture these two windows using Automatic.
  • Specify the capture method to BitBlt and check the hint.

Both windows are captured by WGC correctly, and the hints are displayed correctly when selecting BitBlt.

Testing environment:

  • i9-11900H
  • RTX 3060 Laptop
  • Windows 11 26120.961 (Insider Dev)

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Enhancement Improvement to existing functionality label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants