Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update CEF from 103/5060 to 127/6533 #11213

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Aug 28, 2024

Description

Update CEF from 103/5060 to 127/6533.

Motivation and Context

Many thanks to @reitowo , @WizardCM , @tytan652 , @pkviet , @PatTheMav , @kkartaltepe , @Lain-B , and everyone else who pitched in to answer questions, test, help, and build the packages so that we can update CEF.

How Has This Been Tested?

Built on Windows 11 and ran through some tests with browser sources (FishGL, HTML5Test, CSS3Test, etc.) and browser panels (Twitch Authentication).

More testing is welcome.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX added Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality Seeking Testers Build artifacts on CI labels Aug 28, 2024
@RytoEX RytoEX added this to the OBS Studio 31 milestone Aug 28, 2024
@RytoEX RytoEX self-assigned this Aug 28, 2024
@RytoEX
Copy link
Member Author

RytoEX commented Aug 28, 2024

There will probably be another obs-browser update before this lands. I just wanted to get the PR up so that people could hopefully more easily test.

Copy link
Member

@WizardCM WizardCM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows, everything works as expected.

@RytoEX
Copy link
Member Author

RytoEX commented Aug 30, 2024

This should now be unblocked by 16011f7.

@RytoEX RytoEX merged commit 3559fda into obsproject:master Aug 31, 2024
14 checks passed
@RytoEX RytoEX deleted the update-cef-to-127 branch August 31, 2024 02:38
@nproctorGV
Copy link

nproctorGV commented Nov 21, 2024

Have you noticed the VRAM leak on Windows?

@pkviet
Copy link
Member

pkviet commented Nov 21, 2024

Have you noticed the VRAM leak on Windows?

In early tests, iirc, there used to be a leak but it's been solved.
Are you saying it's still happening in beta ? If so, please file a bug with relevant details. And try to use clean default settings without any third party plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality Seeking Testers Build artifacts on CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants