Add mapping for non-numlocked numpad keys under Wayland #11606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 8, 2024 17:27
Non-numlocked numpad keys (e.g., KP_End, KP_Down, KP_Home, etc.) were not previously mapped under Wayland. This change maps them to their corresponding navigation keys (End, Down, Home, etc.), allowing these keys to be assigned as hotkeys when Num Lock is turned off.
Non-numlocked numpad keys (e.g., KP_End, KP_Down, KP_Home, etc.) were not previously mapped under Wayland. This change maps them to their corresponding navigation keys (End, Down, Home, etc.), allowing these keys to be assigned as hotkeys when Num Lock is turned off.
Non-numlocked numpad keys (e.g., KP_End, KP_Down, KP_Home, etc.) were not previously mapped under Wayland. This change maps them to their corresponding navigation keys (End, Down, Home, etc.), allowing these keys to be assigned as hotkeys when Num Lock is turned off.
|
This is the third PR that has failed to, at the very least, follow our contribution guidelines. It also appears to be the third strike for being nonsense that isn't actually tested or validated in any way. This user will be blocked from further contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request adds mappings for non-numlocked numpad keys under Wayland. Previously, keys such as KP_End, KP_Down, KP_Home, etc. were not assignable as hotkeys when Num Lock was turned off. Now, these keys are mapped to their corresponding navigation keys (End, Down, Home, Page Up/Down, etc.), allowing users to assign them as hotkeys as expected.
Motivation and Context
This change is required because users on Wayland could not assign non-numlocked numpad keys as hotkeys in OBS. It fixes issue #9244 .
How Has This Been Tested?
Turned off Num Lock, then opened Hotkeys settings in OBS.
Pressed Numpad 1 (which maps to KP_End), verified that it now registers as "End".
Repeated the test for other non-numlocked numpad keys (KP_Home, KP_Up, KP_Prior, etc.)
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: