obs-outputs: Use packet time callback for frame-accurate chapter markers #11659
+63
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes chapter markers frame-accurate by using packet timing callback introduced for BPM.
Motivation and Context
When there is a significant delay between a frame being rendered and submitted to the output, e.g. due to lookahead or audio buffering, the chapter markers would previously be too early in the file as there was no way to determine the packet's original rendering time. This change fixes that.
How Has This Been Tested?
Recorded a video at 30 fps with
rc-lookahead=30
, confirmed chapter markers are now inserted with a 1-second delay at the correct frame.Types of changes
Checklist: