Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Sign and notarize macOS builds on new tags #3444

Merged
merged 1 commit into from
Sep 10, 2020
Merged

CI: Sign and notarize macOS builds on new tags #3444

merged 1 commit into from
Sep 10, 2020

Conversation

DDRBoxman
Copy link
Member

@DDRBoxman DDRBoxman commented Sep 10, 2020

Description

If a new tag is created we now sign and notarize the osx build.

Motivation and Context

This should streamline making new releases

How Has This Been Tested?

Ran on staging branch, downloaded dmg and it was signed

Types of changes

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@PatTheMav
Copy link
Member

PatTheMav commented Sep 10, 2020

@DDRBoxman Y u no use xcnotary? I added that to the brewfile for a reason. 😕

There's also a "proper" way to do notarisation on Github CI that doesn't require the base64 homebrew dependency and simplifies the process, I'll try to adapt this later tonight: https://github.com/PatTheMav/obs-websocket/blob/a479f529af1e5bf4214d39cec36fad6e6f101a14/.github/workflows/tag_release.yml#L395

In general notarising the dmg is enough because stapling will be applied recursively if done right, so running xcnotary on the dmg once is sufficient. I'd also suggest always codesigning on macOS anyway in prep for Apple Silicon which would also allow the dmg generated for nightlies to be codesigned (and then just be thrown at the notarisation process on a tag event).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants