-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add capability for native Apple Silicon and Universal binary builds #5155
Conversation
ba01ec6
to
c4906cd
Compare
@GeorgesStavracas Can you make sense of this? The Flatpak step complains:
But the file is clearly there: https://github.com/PatTheMav/obs-studio/blob/universal-build/CI/flatpak/com.obsproject.Studio.json. |
c4906cd
to
271c81b
Compare
So I assume we can now use |
It is a cmake flag. |
Yes but how do I actually apply it? Is it possible to apply it to the CI build script? Because I tried making a directory in the root called
But I got a luajit error. And there was no bottle to install it. Compiling it from source gave me an error so I gave up |
LuaJIT has nothing to do with the browser source. LuaJIT is used in the obs-scripting module. You need the latest LuaJIT 2.1 branch which should be included in our dependencies package. We don't use brew for dependencies. Otherwise, you can disable the scripting module entirely by setting |
This PR is based on the CMake rework - to disable browser sources you have to pass a value for the CMake cache variables are passed using the |
960829b
to
25321d5
Compare
29bbfb4
to
9adf898
Compare
ba482ea
to
568b4ba
Compare
717dff3
to
01a3a53
Compare
Also updates main CMakeLists.txt and CMakeLists.txt for unit tests, also adds additional build directories to .gitignore file
7f71e85
to
01fd3ee
Compare
01fd3ee
to
8fba906
Compare
This comment was marked as abuse.
This comment was marked as abuse.
Download the latest builds from the master branch by checking for the latest build from the obs-studio repository's main page. |
I didn't have a chance to test this before merge in recent times (I guess I might have only tested #4560), so I only now noticed that VST will be required always. Sort of. I do see the ENABLE_VST at https://github.com/obsproject/obs-vst/blob/master/CMakeLists.txt#L39 but that doesn't help if the module isn't there during build. This might be mostly an issue with source-based packaging only, so I wonder how desirable it will be if I (or someone else) includes the check in OBS Studio itself like how it used to be. |
This looks intentional to me (and honestly there really isn't a reason to not have a submodule cloned). |
Well, if nothing else, it seems like unnecessary traffic. :] Looking more into it, it seems the same would happen if obs-browser is missing. Both of them are behind 'ENABLE_PLUGINS', but it's either all or nothing then. |
Is it posible to use the NDI and VLC playlist plugins? |
All built in plugins (like VLC) work. |
Description
Adds the necessary changes to build OBS on macOS for x86_64, arm64, and universal binary builds. Heavy lifting is done by cmake itself (via the
CMAKE_OSX_ARCHITECTURES
flag) which allows compilation for single or dual architectures.Notes:
For the time being this doesn't work with browser source enabled (which it is by default) as we don't have a native patched CEF build for arm64 availableThat said, with browser source functionality disabled, this will compile a fully native Apple Silicon build/tmp
anymore but instead in theobs-build-dependencies
directory used by all other build dependencies. This avoids the issue ofobs-deps
disappearing at reboot (as macOS empties/tmp
) and also makes use of the newobs-deps
not using absolute path IDs in signature anymoreMotivation and Context
How Has This Been Tested?
Types of changes
Checklist: