-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] obs-ffmpeg, hotkey: Implement replay buffer flush and save hotkey #7940
base: master
Are you sure you want to change the base?
[WIP] obs-ffmpeg, hotkey: Implement replay buffer flush and save hotkey #7940
Conversation
eb27054
to
ea79f31
Compare
ea79f31
to
2d8be24
Compare
I definitely welcome help, suggestions, ideas, criticism, etc. This has been a bit of a learning project for me as I'm basically new to the language. 😅 As you can see above I've been back and forth with ideas, and I'm still not sure if I'm on the best path... |
PRs are reviewed as time allows. We're in the middle of the beta phase of a release cycle, so efforts are understandably focused on pure bug fixes rather than new features. It may be some time before someone is able to dig into this. Thank you for your understanding. |
No rush at all. |
After discussion, we don't want this as a checkbox, but we would be fine adding a separate hotkey that allows the user to save the replay buffer and flush it. As a separate matter, it would be more expedient to get the bug fix in if it were submitted separately from a feature PR. |
Good ideas. Will create a new PR for the bug fix and add as a separate
hotkey here ASAP.
Note to self: Keep this in mind:
https://github.com/elgatosf/streamdeck-obs-plugin2
…On Mon, Jan 23, 2023 at 2:23 PM Ryan Foster ***@***.***> wrote:
After discussion, we don't want this as a checkbox, but we would be fine
adding a separate hotkey that allows the user to save the replay buffer and
flush it.
As a separate matter, it would be more expedient to get the bug fix in if
it were submitted separately from a feature PR.
—
Reply to this email directly, view it on GitHub
<#7940 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPORXSDBIKRS5CQEQSLY5DWT4AG7ANCNFSM6AAAAAATCJN5HA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Been using this pull request for a few hours of clips, and it seems to work great. Would be perfect if the second clip started exactly where the first output ended, as it would not require syncing when editing. Currently the second clip starts a bit before the first one ends (around 3 seconds of overlapping footage on my machine) Thanks for this nice feature, been searching for it and found this PR luckily. |
Finally working on implementing this as a hotkey... Will update the above description and take care of the save button (051b4fe) in a separate PR. And, RE:
I believe that is a symptom of only flushing down to two keyframes. IIRC, I ran into issues otherwise. e.g.,
Will see what I can figure out... May need some help on that one. |
2d8be24
to
b84e69b
Compare
6c3a453
to
d07af74
Compare
Hotkey to flush and save the replay buffer. This can help cut down on duplicate footage.
d07af74
to
1d5868a
Compare
Description
Adds simple/advanced output replay buffer setting to allow flushing the replay buffer after the save button or hotkey is pressed.Working on converting to a hotkey.
Motivation and Context
To cut down on duplicate footage in saved replay clips.
How Has This Been Tested?
WIP
Types of changes
Checklist: