Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests: SetVolume: allow volumes > 1.0 #629

Merged
merged 1 commit into from
Dec 20, 2020

Conversation

marcan
Copy link

@marcan marcan commented Dec 9, 2020

Description

Allow volumes > 1.0 / > 0dB, which is legal in OBS (you can do this in Advanced Audio Properties). OBS allows up to +26dB gain, so we do the same. This corresponds to approximately 20x linear gain (actually 19.9526231497, but 20 is easier to explain and OBS doesn't care).

Motivation and Context

This is required to be able to add audio gain to sources that have too low an audio level.

How Has This Been Tested?

A previous version of this patch was tested with OBS master a few months ago, and used in production. I've rebased this on the current version, which added the decibel mode. I think the change is obvious enough that it does not warrant further testing.

Types of changes

  • Documentation change (a change to documentation pages)
  • Enhancement (modification to a current event/request which adds functionality)

Checklist:

  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@marcan
Copy link
Author

marcan commented Dec 14, 2020

FWIW this has now been tested in production too.

@tt2468
Copy link
Member

tt2468 commented Dec 20, 2020

Just a note for the future, only the documentation in the source code needs to be updated, as the docs files are automatically generated.

Allow volumes > 1.0 / > 0dB, which is legal in OBS (you can do this in
Advanced Audio Properties). OBS allows up to +26dB gain, so we do the
same. This corresponds to approximately 20x linear gain (actually
19.9526231497, but 20 is easier to explain and OBS doesn't care).
@tt2468 tt2468 merged commit 8a8ea92 into obsproject:4.x-current Dec 20, 2020
@Palakis Palakis added this to the 4.9 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants