Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verison 3.0.0 #53

Merged
merged 6 commits into from
May 25, 2021
Merged

Verison 3.0.0 #53

merged 6 commits into from
May 25, 2021

Conversation

bbayles
Copy link
Contributor

@bbayles bbayles commented May 23, 2021

This PR is for version 3.0.0. The changes are:

  • boto3 client handling is now simplified. The region_name, profile_name, and boto_client_kwargs have been dropped. You can set the usual AWS environment variables to customize client creation, or pass in clients to the constructors yourself.
  • Support for custom formats on CloudWatch logs has been added. By default they will be automatically detected using the ec2 DescribeFlowLogs API endpoint. You can also pass them in manually with the fields keyword in the library, or the --fields switch on the command line.
  • The reader classes now keep track of the number of bytes_processed.

@mrg29 mrg29 self-requested a review May 25, 2021 14:28
@mrg29
Copy link
Contributor

mrg29 commented May 25, 2021

abridged/edited conversation from Slack:

me:
On this do we need to worry about characters that are more than 1 byte in utf-8?

bbayles:
At the moment it's all ASCII.

@bbayles bbayles merged commit ceda052 into master May 25, 2021
@bbayles bbayles deleted the verison-3.0.0 branch May 25, 2021 18:42
@bbayles bbayles mentioned this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants