Handle AWS parquet format #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbayles
reviewed
Jan 18, 2022
flowlogs_reader/flowlogs_reader.py
Outdated
| def _reader(self): | ||
| for event_data in self._read_streams(): | ||
| yield FlowRecord(event_data) | ||
| if self._has_required_fields(event_data): |
There was a problem hiding this comment.
I think this ought to be up to the caller. That is, some applications will have different required fields, and should not automatically have their formats filtered out.
jmarkey
approved these changes
Jan 24, 2022
|
@jmarkey Thanks for approving it. How is |
I would update our version in |
|
You'll also need Michael or me to push the released version to PyPI after you bump the version and merge. |
|
I bumped the version and merged the PR. Could you @bbayles or @mjschultz release it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/obsrvbl/devops/issues/9009
Add support of AWS parquet format