New direction for handling failed flowrecords #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggestions:
|
|
Added skipped records to the base reader, added all exceptions to the catch (good point) |
|
Dropped the multiple return types and just incremented the counter instead. Consuming modules can check the skipped record value and then log based on that. |
mjschultz
reviewed
Dec 14, 2022
|
removed the unnecessary var creation, direct to yield |
mjschultz
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this is to simply try catch the init of FlowRecord, and if an exception is caught, increment the "skipped_records" field of the basereader class. This value can then be checked and logged in the consuming class for further investigation if warranted. Also added an override during class init to raise the exception instead.