Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move setuptools stuff from setup.py to setup.cfg #13

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Conversation

mrg29
Copy link
Contributor

@mrg29 mrg29 commented Jan 20, 2021

This PR is analogous to this commit from obsrvbl-oss/flowlogs-reader#41.

Changes made, other than the file format:

(1) I did not carry over these lines:

    test_suite='tests',	
    tests_require=[],

Those are for running python setup.py test, which is deprecated and isn't used in the CI file.

(2) This line:

    packages=find_packages(exclude=[]),

should've been this instead:

    packages=find_packages(exclude=['tests']),

I did not carry over the exclude= part at all, but will write a separate PR that fixes it.

@mrg29 mrg29 requested a review from bbayles January 20, 2021 19:16
@bbayles bbayles merged commit a3d4a5b into master Jan 20, 2021
@mrg29 mrg29 deleted the setupcfg branch January 22, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants