-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make reader compatible with google-cloud-logging
v3 releases
#27
Conversation
@@ -25,7 +25,7 @@ classifiers = | |||
packages = find: | |||
python_requires = >=3.6 | |||
install_requires = | |||
google-cloud-logging < 2.0 | |||
google-cloud-logging < 4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the major library upgrade, I think we should bump the version to 3.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is backwards compatible with 1.x and 2.x 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, I'm fine with that... I'm not familiar with how you all have been doing versioning. Was thinking major bumps were reserved for breaking changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to be conservative and we should bump the major version since I'm not sure what dependencies this upgrade entails and the impact it would have on consuming project policies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm |
Co-authored-by: Jeremy McNeal <mcneo@users.noreply.github.com>
Overview
This PR adds support for
google-cloud-logging >= 3.0
... This will transitively requiregoogle-api-core>=2.0
. The primary changes are as follows:projects
argument... It now accepts a list of resources. Internally ifresources
is not provided, it will default to[f'projects/{self.project_id}']
which is the project_id associated with the client. We make use of this argument, so behavior should be 1:1 to what we are doing now (for multi and single project cases.)list_entries
now pages for you in both the http logging_api and the gapic logging_api.