from_coco_dict_or_path, added threading for processing coco_dict["images"] #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for this significant contribution @ilkermanap! Would you mind reformatting your code with |
fcakyon
reviewed
Feb 12, 2023
fcakyon
reviewed
Feb 12, 2023
…essing the json image list
…d commit after run_code_style
fcakyon
approved these changes
Feb 12, 2023
|
@ilkermanap thanks a lot! All tests pass 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added threading for processing the coco_dict["images"] list.
We can provide the number of threads to use. Each thread will process (number of images / number of threads)
Could not test it with the absence of test data.
Added use_threads: bool = False, num_threads: int = 10 parameters to classmethod.