Pin dune and base to work around ocaml trunk changes #472
Conversation
|
CI for OCaml 5.3 is expected to fail due to #471 |
|
Pushed a couple of new commits to use a patched version of |
|
@shakthimaan is my understanding correct that dune would previously not compile against |
punchagan
changed the title
Due to a [recent change] on `ocaml/ocaml` `trunk`, `base.v0.16.3` fails to [install]. `base` is a build dependency of `owl`, which only has sequential benchmarks (no parallel ones). So, the failure happens only for sequential benchmarks. Parallel ones run alright. Closes ocaml-bench#470 [recent change]: ocaml/ocaml#13169 [install]: ocaml-bench/sandmark-nightly@197c9bd#diff-c635461b488c1e7d7b7feaf5fcb01945d54f84c512cf4db7e2dc390a2a23c5e8R456-R476
ocaml/ocaml@51e5cf2 split the compiler flags for native and bytecode compiler to separate flags. It also changes the flag names which breaks builds of several packages. This commit is a workaround for that change.
|
Sure. It will be good to decide on LTS and whether you need to support earlier versions. Otherwise, it is better to upgrade. |
|
Makes sense. I guess we could make the "use_sys_dune" an option in the configuration files, if we'd like to support older versions alongside the current versions. I've not removed the |
|
Deployed |
|
Builds on navajo are running again! |
The primary changes in this PR are:
baseto workaround Format_doc change (see commit message)duneto workaround splitting native and bytecode compiler flags (see commit message)The PR also has other small changes:
duneto latest version