Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect XDG for the inputrc config file #86

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Conversation

copy
Copy link
Contributor

@copy copy commented Apr 19, 2020

Moves the .lambda-term-inputrc config file to ~/.config/.lambda-term-inputrc.

Prints a warning if ~/.lambda-term-inputrc exists, but still uses it.

@copy copy requested a review from a user April 19, 2020 14:56
@kandu
Copy link
Collaborator

kandu commented Apr 20, 2020

Nice, it's a harmony of the recent utop enhancement(XDG folder).
@pmetzger, what do you think?

@kandu kandu merged commit 03b0b9a into ocaml-community:master Apr 24, 2020
@kandu
Copy link
Collaborator

kandu commented Apr 24, 2020

merged, thank you, @copy

@copy
Copy link
Contributor Author

copy commented Apr 24, 2020

Thanks!

@frou
Copy link

frou commented Aug 2, 2020

@copy isn't the convention that once such files are inside ~/.config/ then they shouldn't have a leading dot? They no longer need to be "hidden" since their containing directory is itself hidden.

@copy
Copy link
Contributor Author

copy commented Aug 7, 2020

@frou Good point, you're absolutely right. @kandu What do you think about renaming the file to ~/.config/lambda-term-inputrc?

@kandu
Copy link
Collaborator

kandu commented Aug 8, 2020

Neither of us spotted this flaw 😑

What do you think about renaming the file to ~/.config/lambda-term-inputrc?

This is the quickest fix. We can apply it and cut a minor release. But shall we keep backward compatibility for the period of the major versions(3.x.x) before applying it? That is, cut a minor/patch version, with the dot-stripped file name inserted to the head of config file priority list.

When the time comes to bump the major version, we can revert this change and simply rename the file name.

@copy
Copy link
Contributor Author

copy commented Aug 9, 2020

@Kanda Good idea, will send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants