Do not display a backtrace when exiting normally #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emillon
force-pushed
the
exit-with-status-no-backtrace
branch
from
0981035 to
8243309
Compare
|
Not 100% it's always the right move, so I'm giving it a bit of time for discussion. |
Exiting normally here refers to the `Exit_with_status` exception. It is in particular triggered by `#quit;;` so we want to exit quietly in that case. Closes ocaml-community#398
emillon
force-pushed
the
exit-with-status-no-backtrace
branch
from
8243309 to
3944784
Compare
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Jan 5, 2023
CHANGES: * Bump the compatibility to 4.08+ (ocaml-community/utop#393 @emillon) * Load `@toplevel_printer` annotated printers for functors (ocaml-community/utop#378 @metavinek) * Do not display a backtrace when exiting normally (ocaml-community/utop#399 ocaml-community/utop#398 @emillon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exiting normally here refers to the
Exit_with_statusexception. It is in particular triggered by#quit;;so we want to exit quietly in that case.Closes #398