Qualify () constructor #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are building a hidden expression that contains "()" but it is not qualified. So it will pick the constructor in scope. This can cause problems if `()` has been redefined. The correct fix is to qualify it as part of the `Unit` module. (additionally, this removes an unused ident) Fixes ocaml-community#417
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Apr 17, 2023
CHANGES: * Add support for OCaml 5.1 (ocaml-community/utop#421, @emillon) * Mark `prompt_continue`, `prompt_comment`, `smart_accept`, `new_prompt_hooks`, `at_new_prompt` as deprecated (they have been documented as such since 2012 and most of them are ignored) (ocaml-community/utop#415, @emillon) * Qualify `()` constructor in generated expressions. (ocaml-community/utop#418, fixes ocaml-community/utop#417, @emillon)
|
An issue with this change just appeared: the fails with |
This was referenced Apr 20, 2023
emillon
added a commit
to emillon/utop
that referenced
this pull request
Apr 21, 2023
Fixes ocaml-community#428 The change in ocaml-community#418 introduced a regression if a `Unit` module in scope does not have a `()` constructor in it. This switches to the more explicit `Stdlib.Unit.()` path.
emillon
added a commit
to emillon/utop
that referenced
this pull request
Apr 21, 2023
Fixes ocaml-community#428 The change in ocaml-community#418 introduced a regression if a `Unit` module in scope does not have a `()` constructor in it. This switches to the more explicit `Stdlib.Unit.()` path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are building a hidden expression that contains "()" but it is not
qualified. So it will pick the constructor in scope. This can cause
problems if
()has been redefined. The correct fix is to qualify it aspart of the
Unitmodule.(additionally, this removes an unused ident)
Fixes #417