Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add predefined types for tagged int8 and int16 #3347

Merged
merged 11 commits into from
Dec 20, 2024
Merged

Add predefined types for tagged int8 and int16 #3347

merged 11 commits into from
Dec 20, 2024

Conversation

jvanburen
Copy link
Contributor

I also created modules for them in Stdlib_beta

@jvanburen jvanburen requested a review from ccasin December 6, 2024 18:15
@jvanburen jvanburen self-assigned this Dec 6, 2024
@jvanburen jvanburen changed the title Add predefined types for int8 and int16 Add predefined types for tagged int8 and int16 Dec 6, 2024
@jvanburen
Copy link
Contributor Author

This will be a prerequisite for unboxed int8 and int16 types

ccasin
ccasin reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@ccasin ccasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, mostly minor suggestions.

testsuite/tests/lib-smallint/test_int16.ml Outdated Show resolved Hide resolved
testsuite/tests/typing-small-numbers/test_beta.ml Show resolved Hide resolved
testsuite/tests/typing-small-numbers/test_beta.ml Show resolved Hide resolved
otherlibs/stdlib_beta/int16.ml Show resolved Hide resolved
otherlibs/stdlib_beta/int16.mli Show resolved Hide resolved
otherlibs/stdlib_beta/int16.ml Outdated Show resolved Hide resolved
testsuite/tests/lib-smallint/test_int16.ml Outdated Show resolved Hide resolved
testsuite/tests/lib-smallint/test_int8.ml Show resolved Hide resolved
testsuite/tests/lib-smallint/test_int8.ml Outdated Show resolved Hide resolved
testsuite/tests/lib-smallint/test_int8.ml Outdated Show resolved Hide resolved
@jvanburen jvanburen enabled auto-merge (squash) December 20, 2024 15:44
ccasin
ccasin approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ccasin ccasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, but eagerly approving now. Thanks!

otherlibs/stdlib_beta/int.ml Outdated Show resolved Hide resolved
otherlibs/stdlib_beta/.ocamlformat-enable Outdated Show resolved Hide resolved
otherlibs/stdlib_beta/int.ml Outdated Show resolved Hide resolved
@jvanburen jvanburen merged commit efc5211 into main Dec 20, 2024
20 checks passed
@jvanburen jvanburen deleted the tagged-small-ints branch December 20, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccasin ccasin ccasin approved these changes

Assignees

@jvanburen jvanburen

Labels
typing unboxed types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvanburen @ccasin @mshinwell