Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a benign data-race in Chan reported by ocaml-tsan #103

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

art-w
Copy link
Contributor

@art-w art-w commented Jan 14, 2023

tsan thinks that the previous code looked weird and I tend to agree (but I'm guessing it can't actually go bad?)

Now to confuse the reviewers and for context, the ref updates outside the mutex was introduced in #24 (e81e1f5), so there might be reasons for doing it that way? (cc @ctk21 in case you remember) (Should we rather switch the ref to an atomic?)

@kayceesrk
Copy link
Contributor

Thanks @art-w.

Sudha247 added a commit to Sudha247/opam-repository that referenced this pull request Jul 18, 2023
CHANGES:

* Add parallel_find (ocaml-multicore/domainslib#90, @gasche)
* Update CI (ocaml-multicore/domainslib#93, @Sudha247)
* Optimisation to work-stealing (ocaml-multicore/domainslib#96, @art-w)
* Improve docs presentation (ocaml-multicore/domainslib#99, @metanivek)
* Property based tests (ocaml-multicore/domainslib#100, jmid)
* Task: avoid double handler installation (ocaml-multicore/domainslib#101, @gasche & @clef-men)
* Fix a benign data-race in Chan reported by ocaml-tsan (ocaml-multicore/domainslib#103, @art-w)
* Dune, opam, and GitHub Actions fixes (ocaml-multicore/domainslib#105, @MisterDA)
* domain local await support (ocaml-multicore/domainslib#107, @polytypic)
* Windows run on GitHub Actions (ocaml-multicore/domainslib#110, @Sudha247)
* Adjust PBTs based on recommended_domain_count (ocaml-multicore/domainslib#112, @jmid)
* Test condition tweaks (ocaml-multicore/domainslib#113, @jmid)
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
CHANGES:

* Add parallel_find (ocaml-multicore/domainslib#90, @gasche)
* Update CI (ocaml-multicore/domainslib#93, @Sudha247)
* Optimisation to work-stealing (ocaml-multicore/domainslib#96, @art-w)
* Improve docs presentation (ocaml-multicore/domainslib#99, @metanivek)
* Property based tests (ocaml-multicore/domainslib#100, jmid)
* Task: avoid double handler installation (ocaml-multicore/domainslib#101, @gasche & @clef-men)
* Fix a benign data-race in Chan reported by ocaml-tsan (ocaml-multicore/domainslib#103, @art-w)
* Dune, opam, and GitHub Actions fixes (ocaml-multicore/domainslib#105, @MisterDA)
* domain local await support (ocaml-multicore/domainslib#107, @polytypic)
* Windows run on GitHub Actions (ocaml-multicore/domainslib#110, @Sudha247)
* Adjust PBTs based on recommended_domain_count (ocaml-multicore/domainslib#112, @jmid)
* Test condition tweaks (ocaml-multicore/domainslib#113, @jmid)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants