Document that non-commutative operators are okay #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right. A quick pen-and-paper checking made me conclude it's the case for parallel scan as well, but I could be wrong. Thanks for the edits! |
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Oct 11, 2022
CHANGES: This release includes: * Bug fix for `parallel_for_reduce` on empty loops. * Make Chan.t and Task.promise injective ocaml-multicore/domainslib#69 * Add lockfree dependency ocaml-multicore/domainslib#70 * CI fixes (ocaml-multicore/domainslib#73, ocaml-multicore/domainslib#76) * Breaking change: Rename `num_additional_domains` to `num_domains` for setup_pool * Documentation updates (ocaml-multicore/domainslib#80, ocaml-multicore/domainslib#81, ocaml-multicore/domainslib#82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really could not find any reason why the current code would fail for non-commutative (but associative) operators. So, here's my PR to update the documentation. The more complicated case is
parallel_scanwhich deserves extra checking.This would close #79.