Correct the backend selection for Cygwin #557

dra27 · 2023-06-17T12:03:12Z

os-family = "windows" covers both native Windows (os = "win32") and Cygwin (os = "cygwin"). Cygwin is a posix implementation, so it should be using eio_posix.

I encountered this while checking something else in opam-repository, so I haven't actually tried it with a Cygwin 5.1 switch, but if eio_posix isn't building on Cygwin, I would very strongly expect that to be a bug in eio_posix rather than that eio should actually be using eio_windows.

talex5

Thanks! Just to confirm: "win32" means "64-bit Windows"?

CI failed downloading "ocamlbuild.0.14.2+win" so I've restarted it. Update: still failing.

dra27 · 2023-06-19T09:58:20Z

Thanks! Just to confirm: "win32" means "64-bit Windows"?

Yes😉 It refers to the API - back in the nineties, there was Win16 and Win32... in a piece of marketing excellence, Microsoft decided Win64 would be really confusing, so to emphasise compatibility, 64-bit Windows has an API with 32 in the name 🤷

CI failed downloading "ocamlbuild.0.14.2+win" so I've restarted it. Update: still failing.

Looking into this, although at low speed... it's not strictly related to this PR (@polytypic is also seeing it)

talex5 · 2023-06-19T15:54:39Z

The opam problem is tracked at ocaml/opam-repository#23954.

Oddly, it first says it downloaded it, and then that it couldn't:

[ocamlbuild.0.14.2+win] downloaded from https://github.com/ocaml/ocamlbuild/archive/refs/tags/0.14.2.tar.gz
...
[ERROR] The sources of the following couldn't be obtained, aborting:
          - ocamlbuild.0.14.2+win

It downloads OK for me.

talex5 · 2023-06-26T12:57:48Z

I tried rebuilding now the original issue is fixed. CI has been running for over 4 hours now, though!

talex5 · 2023-06-27T08:14:20Z

Windows CI is now failing with:

 -> installed yojson.2.1.0
Terminate batch job (Y/N)? 
^C[ERROR] User interruption


<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
+- The following actions failed
| - build mdx 2.3.0
+-

(after running for 5h 56m!)

Another build failed after 5h 55m with:

-> installed yojson.2.1.0
Terminate batch job (Y/N)? 
^C[ERROR] User interruption


<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
+- The following actions failed
| - build stdlib-shims 0.3.0
+-

talex5 · 2023-07-12T12:21:40Z

I rebased it and updated the dune-project file.

@talex5

CHANGES: New features / API changes: - Extend `Eio.Condition` API (@talex5 ocaml-multicore/eio#563). - `loop_no_mutex` is a simpler and more efficient way to way for a condition. - `register_immediate` allows integration with other IO libraries. - Expose `Eio.Stdenv.backend_id` (@bord-o ocaml-multicore/eio#560, reviewed by @talex5). Useful in tests to report which backend is being used. - Remove deprecated features (@talex5 ocaml-multicore/eio#552, reviewed by @avsm). These were all already marked as deprecated in v0.10 and are now gone completely: - `Fiber.fork_sub` - `Eio_unix.{FD,Ipaddr,socketpair,getnameinfo}` - `Eio_linux.{FD,get_fd,get_fd_opt}` - `Eio_posix.Low_level.Fd` - Allow calling `close` more than once (@talex5 ocaml-multicore/eio#547, requested by @anmonteiro, reviewed by @patricoferris, @avsm). - Add `close` to socket type (@talex5 ocaml-multicore/eio#549). Simplifies the type signatures a bit by avoiding having to mention this everywhere. Bug fixes: - Fix handling of empty path strings (@talex5 ocaml-multicore/eio#569, reported by @SGrondin). Using "" instead of "." in some places resulted in an error. - eio_posix: fix update to watched FDs on cancel (@talex5 ocaml-multicore/eio#574, reported and reviewed by @quernd). Cancelling the last watcher of an FD didn't remove it from the set passed to `poll`, which could result in constant wake-ups. - eio_posix: fix `pread` at end-of-file (@talex5 ocaml-multicore/eio#581, reported by @SGrondin). It tried to return 0 instead of `End_of_file`, triggering an assertion. - eio_posix: don't reap non-Eio child processes (@talex5 ocaml-multicore/eio#562). This allows spawning processes with e.g. the stdlib or Lwt (but see ocaml-multicore/lwt_eio#19 for Lwt support). - Preserve backtraces across `Domain_manager.run` (@talex5 ocaml-multicore/eio#571). See ocaml/ocaml#12362. - Correct the backend selection for Cygwin (@dra27 ocaml-multicore/eio#557). Use `eio_posix`, not `eio_windows` in this case. Other changes: - Simplify dune files with dune 3.9's `build_if` (@talex5 ocaml-multicore/eio#582). - Remove `Waiters` from `Eio_core` (@talex5 ocaml-multicore/eio#567). `Eio.Switch` no longer uses this so it can finally be removed. - Use `Fmt.Dump.signal` to format signals (@talex5, @MisterDA ocaml-multicore/eio#543). Documentation: - Add some notes about thread-safety in the documentation (@talex5 ocaml-multicore/eio#568).

@talex5

CHANGES: New features / API changes: - Extend `Eio.Condition` API (@talex5 ocaml-multicore/eio#563). - `loop_no_mutex` is a simpler and more efficient way to way for a condition. - `register_immediate` allows integration with other IO libraries. - Expose `Eio.Stdenv.backend_id` (@bord-o ocaml-multicore/eio#560, reviewed by @talex5). Useful in tests to report which backend is being used. - Remove deprecated features (@talex5 ocaml-multicore/eio#552, reviewed by @avsm). These were all already marked as deprecated in v0.10 and are now gone completely: - `Fiber.fork_sub` - `Eio_unix.{FD,Ipaddr,socketpair,getnameinfo}` - `Eio_linux.{FD,get_fd,get_fd_opt}` - `Eio_posix.Low_level.Fd` - Allow calling `close` more than once (@talex5 ocaml-multicore/eio#547, requested by @anmonteiro, reviewed by @patricoferris, @avsm). - Add `close` to socket type (@talex5 ocaml-multicore/eio#549). Simplifies the type signatures a bit by avoiding having to mention this everywhere. Bug fixes: - Fix handling of empty path strings (@talex5 ocaml-multicore/eio#569, reported by @SGrondin). Using "" instead of "." in some places resulted in an error. - eio_posix: fix update to watched FDs on cancel (@talex5 ocaml-multicore/eio#574, reported and reviewed by @quernd). Cancelling the last watcher of an FD didn't remove it from the set passed to `poll`, which could result in constant wake-ups. - eio_posix: fix `pread` at end-of-file (@talex5 ocaml-multicore/eio#581, reported by @SGrondin). It tried to return 0 instead of `End_of_file`, triggering an assertion. - eio_posix: don't reap non-Eio child processes (@talex5 ocaml-multicore/eio#562). This allows spawning processes with e.g. the stdlib or Lwt (but see ocaml-multicore/lwt_eio#19 for Lwt support). - Preserve backtraces across `Domain_manager.run` (@talex5 ocaml-multicore/eio#571). See ocaml/ocaml#12362. - Correct the backend selection for Cygwin (@dra27 ocaml-multicore/eio#557). Use `eio_posix`, not `eio_windows` in this case. Other changes: - Simplify dune files with dune 3.9's `build_if` (@talex5 ocaml-multicore/eio#582). - Remove `Waiters` from `Eio_core` (@talex5 ocaml-multicore/eio#567). `Eio.Switch` no longer uses this so it can finally be removed. - Use `Fmt.Dump.signal` to format signals (@talex5, @MisterDA ocaml-multicore/eio#543). Documentation: - Add some notes about thread-safety in the documentation (@talex5 ocaml-multicore/eio#568).

This is to match the change in ocaml-multicore#557.

@talex5

CHANGES: New features / API changes: - Extend `Eio.Condition` API (@talex5 ocaml-multicore/eio#563). - `loop_no_mutex` is a simpler and more efficient way to way for a condition. - `register_immediate` allows integration with other IO libraries. - Expose `Eio.Stdenv.backend_id` (@bord-o ocaml-multicore/eio#560, reviewed by @talex5). Useful in tests to report which backend is being used. - Remove deprecated features (@talex5 ocaml-multicore/eio#552, reviewed by @avsm). These were all already marked as deprecated in v0.10 and are now gone completely: - `Fiber.fork_sub` - `Eio_unix.{FD,Ipaddr,socketpair,getnameinfo}` - `Eio_linux.{FD,get_fd,get_fd_opt}` - `Eio_posix.Low_level.Fd` - Allow calling `close` more than once (@talex5 ocaml-multicore/eio#547, requested by @anmonteiro, reviewed by @patricoferris, @avsm). - Add `close` to socket type (@talex5 ocaml-multicore/eio#549). Simplifies the type signatures a bit by avoiding having to mention this everywhere. Bug fixes: - Fix handling of empty path strings (@talex5 ocaml-multicore/eio#569, reported by @SGrondin). Using "" instead of "." in some places resulted in an error. - eio_posix: fix update to watched FDs on cancel (@talex5 ocaml-multicore/eio#574, reported and reviewed by @quernd). Cancelling the last watcher of an FD didn't remove it from the set passed to `poll`, which could result in constant wake-ups. - eio_posix: fix `pread` at end-of-file (@talex5 ocaml-multicore/eio#581, reported by @SGrondin). It tried to return 0 instead of `End_of_file`, triggering an assertion. - eio_posix: don't reap non-Eio child processes (@talex5 ocaml-multicore/eio#562). This allows spawning processes with e.g. the stdlib or Lwt (but see ocaml-multicore/lwt_eio#19 for Lwt support). - Preserve backtraces across `Domain_manager.run` (@talex5 ocaml-multicore/eio#571). See ocaml/ocaml#12362. - Correct the backend selection for Cygwin (@dra27 ocaml-multicore/eio#557). Use `eio_posix`, not `eio_windows` in this case. Other changes: - Simplify dune files with dune 3.9's `build_if` (@talex5 ocaml-multicore/eio#582). - Remove `Waiters` from `Eio_core` (@talex5 ocaml-multicore/eio#567). `Eio.Switch` no longer uses this so it can finally be removed. - Use `Fmt.Dump.signal` to format signals (@talex5, @MisterDA ocaml-multicore/eio#543). Documentation: - Add some notes about thread-safety in the documentation (@talex5 ocaml-multicore/eio#568).

dra27 mentioned this pull request Jun 17, 2023

Fix various Windows depends/available fields ocaml/opam-repository#23946

Merged

talex5 approved these changes Jun 19, 2023

View reviewed changes

dra27 force-pushed the cygwin-opam-file branch from 7ca03ee to 17e664a Compare June 24, 2023 15:53

Restrict Windows, not Windows+Cygwin

406efc8

talex5 force-pushed the cygwin-opam-file branch from 17e664a to 406efc8 Compare July 12, 2023 11:23

talex5 merged commit b3b3c9f into ocaml-multicore:main Jul 12, 2023
3 of 4 checks passed

talex5 mentioned this pull request Jul 12, 2023

[new release] eio (5 packages) (0.11) ocaml/opam-repository#24099

Merged

talex5 added a commit to talex5/eio that referenced this pull request Jul 19, 2023

eio_windows: update available line to win32

0ed36c9

This is to match the change in ocaml-multicore#557.

talex5 mentioned this pull request Jul 20, 2023

eio_windows: update available line to win32 #588

Merged

talex5 added a commit to talex5/eio that referenced this pull request Jul 20, 2023

eio_windows: update available line to win32

5c5aa23

This is to match the change in ocaml-multicore#557.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correct the backend selection for Cygwin #557

Correct the backend selection for Cygwin #557

dra27 commented Jun 17, 2023

talex5 left a comment •

edited

Loading

dra27 commented Jun 19, 2023 •

edited

Loading

talex5 commented Jun 19, 2023

talex5 commented Jun 26, 2023

talex5 commented Jun 27, 2023

talex5 commented Jul 12, 2023

Correct the backend selection for Cygwin #557

Correct the backend selection for Cygwin #557

Conversation

dra27 commented Jun 17, 2023

talex5 left a comment • edited Loading

Choose a reason for hiding this comment

dra27 commented Jun 19, 2023 • edited Loading

talex5 commented Jun 19, 2023

talex5 commented Jun 26, 2023

talex5 commented Jun 27, 2023

talex5 commented Jul 12, 2023

talex5 left a comment •

edited

Loading

dra27 commented Jun 19, 2023 •

edited

Loading