eio_posix: fix filesystem tests on OpenBSD #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 'resolve' function there is a check for items being symlinks which was missing ELOOP as an indicator. This patch adds ELOOP, to match the similar check in 'open_beneath_fallback'. This fixes filesystem tests on OpenBSD.
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
May 28, 2024
CHANGES: New features: - Add `Eio.Path.symlink` (@patricoferris ocaml-multicore/eio#715, reviewed by @talex5). - Add `Eio.Pool.use ~never_block` (@SGrondin ocaml-multicore/eio#657, reviewed by @talex5). - Add `Eio_unix.Net.import_socket_listening` (@alyssais ocaml-multicore/eio#733). - Add `Eio.Time.Timeout.sleep` (@talex5 ocaml-multicore/eio#726). Documentation: - Add `examples/fs` showing how to walk a directory tree (@talex5 ocaml-multicore/eio#730). - README: explain that `read_all` reads until shutdown (@talex5 ocaml-multicore/eio#717, reported by @Wenke-D). - Use long dash in README title (@lucperkins ocaml-multicore/eio#718). Linux backend: - Require Linux >= 5.15 (@talex5 ocaml-multicore/eio#720, reviewed by @SGrondin and @avsm). Removes a work-around that required checking whether every flow was a tty. - Don't call submit immediately before wait (@talex5 ocaml-multicore/eio#728). This is slightly faster and makes the traces clearer. - Don't record submit events when there's nothing to submit (@talex5 ocaml-multicore/eio#729). Makes the traces a bit clearer. - Split flow into its own file (@talex5 ocaml-multicore/eio#727). - Add work-around for signals race (@talex5 ocaml-multicore/eio#734). POSIX backend: - Add `_BSD_SOURCE` flag to fix build on OpenBSD (@prgbln ocaml-multicore/eio#722). - Fix sandboxed path resolution on OpenBSD (@jebrosen ocaml-multicore/eio#723, reviewed by @talex5). OpenBSD uses `ELOOP` when opening a symlink with `O_NOFOLLOW`. Build and test: - Benchmarks: record uname, Eio backend, and number of cores (@talex5 ocaml-multicore/eio#719). - Update to MDX 2.4.1 for OCaml 5.2 (@talex5 ocaml-multicore/eio#712).
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
May 28, 2024
CHANGES: New features: - Add `Eio.Path.symlink` (@patricoferris ocaml-multicore/eio#715, reviewed by @talex5). - Add `Eio.Pool.use ~never_block` (@SGrondin ocaml-multicore/eio#657, reviewed by @talex5). - Add `Eio_unix.Net.import_socket_listening` (@alyssais ocaml-multicore/eio#733, reviewed by @talex5). - Add `Eio.Time.Timeout.sleep` (@talex5 ocaml-multicore/eio#726). Documentation: - Add `examples/fs` showing how to walk a directory tree (@talex5 ocaml-multicore/eio#730). - README: explain that `read_all` reads until shutdown (@talex5 ocaml-multicore/eio#717, reported by @Wenke-D). - Use long dash in README title (@lucperkins ocaml-multicore/eio#718). Linux backend: - Require Linux >= 5.15 (@talex5 ocaml-multicore/eio#720, reviewed by @SGrondin and @avsm). Removes a work-around that required checking whether every flow was a tty. - Don't call submit immediately before wait (@talex5 ocaml-multicore/eio#728). This is slightly faster and makes the traces clearer. - Don't record submit events when there's nothing to submit (@talex5 ocaml-multicore/eio#729). Makes the traces a bit clearer. - Split flow into its own file (@talex5 ocaml-multicore/eio#727). - Add work-around for signals race (@talex5 ocaml-multicore/eio#734). POSIX backend: - Add `_BSD_SOURCE` flag to fix build on OpenBSD (@prgbln ocaml-multicore/eio#722). - Fix sandboxed path resolution on OpenBSD (@jebrosen ocaml-multicore/eio#723, reviewed by @talex5). OpenBSD uses `ELOOP` when opening a symlink with `O_NOFOLLOW`. Build and test: - Benchmarks: record uname, Eio backend, and number of cores (@talex5 ocaml-multicore/eio#719). - Update to MDX 2.4.1 for OCaml 5.2 (@talex5 ocaml-multicore/eio#712).
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: New features: - Add `Eio.Path.symlink` (@patricoferris ocaml-multicore/eio#715, reviewed by @talex5). - Add `Eio.Pool.use ~never_block` (@SGrondin ocaml-multicore/eio#657, reviewed by @talex5). - Add `Eio_unix.Net.import_socket_listening` (@alyssais ocaml-multicore/eio#733, reviewed by @talex5). - Add `Eio.Time.Timeout.sleep` (@talex5 ocaml-multicore/eio#726). Documentation: - Add `examples/fs` showing how to walk a directory tree (@talex5 ocaml-multicore/eio#730). - README: explain that `read_all` reads until shutdown (@talex5 ocaml-multicore/eio#717, reported by @Wenke-D). - Use long dash in README title (@lucperkins ocaml-multicore/eio#718). Linux backend: - Require Linux >= 5.15 (@talex5 ocaml-multicore/eio#720, reviewed by @SGrondin and @avsm). Removes a work-around that required checking whether every flow was a tty. - Don't call submit immediately before wait (@talex5 ocaml-multicore/eio#728). This is slightly faster and makes the traces clearer. - Don't record submit events when there's nothing to submit (@talex5 ocaml-multicore/eio#729). Makes the traces a bit clearer. - Split flow into its own file (@talex5 ocaml-multicore/eio#727). - Add work-around for signals race (@talex5 ocaml-multicore/eio#734). POSIX backend: - Add `_BSD_SOURCE` flag to fix build on OpenBSD (@prgbln ocaml-multicore/eio#722). - Fix sandboxed path resolution on OpenBSD (@jebrosen ocaml-multicore/eio#723, reviewed by @talex5). OpenBSD uses `ELOOP` when opening a symlink with `O_NOFOLLOW`. Build and test: - Benchmarks: record uname, Eio backend, and number of cores (@talex5 ocaml-multicore/eio#719). - Update to MDX 2.4.1 for OCaml 5.2 (@talex5 ocaml-multicore/eio#712).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like someone beat me to it on OpenBSD compilation (#722), but I did see some failures in the test suite and found a solution. This fix seems reasonable to me, but I definitely might have missed something - these two functions have differed on this check since they were first introduced in #694.
In the 'resolve' function there is a check for items being symlinks which was missing ELOOP as an indicator. This patch adds ELOOP, to match the similar check in 'open_beneath_fallback'.
This fixes filesystem tests on OpenBSD.