Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ocamlformat-bench binary private #2104

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Conversation

gpetiot
Copy link
Collaborator

@gpetiot gpetiot commented Jun 10, 2022

Follow-up on #2101 (better fix for #2100)

CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@gpetiot gpetiot merged commit 90210b1 into ocaml-ppx:main Jun 10, 2022
@gpetiot gpetiot deleted the private-bench branch June 10, 2022 18:58
kit-ty-kate pushed a commit to ocaml/opam-repository that referenced this pull request Jul 7, 2022
CHANGES:

### Removed

- `bench` binary is not distributed anymore to avoid name collisions (ocaml-ppx/ocamlformat#2104, @gpetiot)

### Deprecated

### Bug fixes

- Preserve comments around object open/close flag (ocaml-ppx/ocamlformat#2097, @trefis, @gpetiot)
- Preserve comments around private/mutable/virtual keywords (ocaml-ppx/ocamlformat#2098, @trefis, @gpetiot)
- Closing parentheses of local open now comply with `indicate-multiline-delimiters` (ocaml-ppx/ocamlformat#2116, @gpetiot)
- emacs: fix byte-compile warnings (ocaml-ppx/ocamlformat#2119, @syohex)

### Changes

- Use the API of ocp-indent to parse the `.ocp-indent` files (ocaml-ppx/ocamlformat#2103, @gpetiot)
- JaneStreet profile: set `max-indent = 2` (ocaml-ppx/ocamlformat#2099, @gpetiot)
- JaneStreet profile: align pattern-matching bar `|` under keyword instead of parenthesis (ocaml-ppx/ocamlformat#2102, @gpetiot)

### New features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants