Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly format chunks of file in presence of enable/disable floating attributes #2156

Merged
merged 15 commits into from
Sep 21, 2022

Conversation

gpetiot
Copy link
Collaborator

@gpetiot gpetiot commented Sep 9, 2022

Fix #1545

lib/Fmt_ast.ml Outdated Show resolved Hide resolved
lib/Fmt_ast.ml Outdated Show resolved Hide resolved
test/passing/tests/comments_around_disabled.ml Outdated Show resolved Hide resolved
@gpetiot gpetiot force-pushed the fix-enable-disable-attrs branch from c7c46df to bdd6dc2 Compare September 21, 2022 12:52
CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@gpetiot gpetiot requested a review from Julow September 21, 2022 13:36
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@gpetiot gpetiot merged commit d74b310 into ocaml-ppx:main Sep 21, 2022
@gpetiot gpetiot deleted the fix-enable-disable-attrs branch September 21, 2022 17:44
EmileTrotignon pushed a commit to EmileTrotignon/ocamlformat that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docstring parsing fails with [@@@ocamlformat "disable"]
3 participants