Preserve sugared extension node attached to an 'if' carrying attributes #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
gpetiot
force-pushed
the
ifthenelse-branch
branch
from
eb40fb2 to
b8842d2
Compare
Julow
approved these changes
Oct 5, 2022
gpetiot
force-pushed
the
ifthenelse-branch
branch
from
b8842d2 to
2fe5ece
Compare
EmileTrotignon
pushed a commit
to EmileTrotignon/ocamlformat
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from ocamlformat-ng's concrete AST in our long-running effort to make the AST closer to the original source.
In this one the sugaring of if-then-else expressions is moved from Sugar.ml to the parser, removing intermediary locations. Also one step closer to have the AST (soon CST) handle attributes and extension nodes better.
No diff found with test_branch.sh for the 3 profiles.