Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ast_mapper.map_function_param should call arg_label #2473

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

gpetiot
Copy link
Collaborator

@gpetiot gpetiot commented Nov 6, 2023

This caused a bug on test-extra/code/base/src/map_intf.ml caught by the CI of #2472, but introduced on main in #2471 (code was copied from the compiler in #2466).

edit: the code in the compiler doesn't contain a function to map arg_labels, so nothing to fix on the compiler.

@gpetiot gpetiot added the no changelog set this to bypass the CI check for changelog entries label Nov 6, 2023
@gpetiot gpetiot merged commit 4e2a618 into ocaml-ppx:main Nov 6, 2023
@gpetiot gpetiot deleted the fix-max-function-param branch November 6, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog set this to bypass the CI check for changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant