Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the tool name pass throught when used as a -ppx #41

Merged
1 commit merged into from
Sep 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 4, 2018

This is needed for ppx_import

@ghost ghost requested a review from xclerc as a code owner September 4, 2018 14:24
@ghost ghost mentioned this pull request Sep 4, 2018
CHANGES.md Outdated
@@ -3,6 +3,8 @@ next

- Add `Attribute.declare_with_name_loc` (#.., @diml)

- Let the tool name pass throught when used as a -ppx (#..., @diml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update with the PR name (same two lines up).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
@ghost ghost force-pushed the let-tool_name-pass-through branch from e30a860 to 0c4f9ff Compare September 5, 2018 09:39
@ghost ghost merged commit 5d218bd into master Sep 5, 2018
ghost pushed a commit that referenced this pull request Feb 13, 2019
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
@NathanReb NathanReb deleted the let-tool_name-pass-through branch February 14, 2024 09:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants