Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(pin-artifacts.yml): Add build artifacts links within upstream commits status #501

Merged
merged 3 commits into from
Nov 26, 2022
Merged

ci(pin-artifacts.yml): Add build artifacts links within upstream commits status #501

merged 3 commits into from
Nov 26, 2022

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Nov 26, 2022 •
edited
Loading

Description

Make it easier for end-users to download static binaries from unmerged PRs.

Note: due to the standard permissions enforced by GitHub, the provided links require end users to be logged in github.com, and only work for 90 days.

@yurug: as this PR is not critical but very useful to address #475, and it can't be tested anew (beyond my separated test below) before the new .yml is part of the repo itself, I plan to merge it tonight; but feel free to comment meanwhile anyway, if need be!

Screenshots as a demo

cf. https://github.com/pfitaxel/learn-ocaml-issue475-poc :

In commit statuses

2022-11-26_16-49-10_Screenshot_issue475-poc_commit

In PR checks

2022-11-26_16-49-41_Screenshot_issue475-poc_PR

Checklist

Note to maintainers

  • Read this wiki page
  • Make sure the PR has a milestone
  • Assign yourself before merging
  • This PR needs to be squash-merged (the first commit, reverted later, can be useful for historical reasons)

@erikmd erikmd self-assigned this Nov 26, 2022
@erikmd erikmd added the kind: enhancement Enhancement to an existing user-facing feature. label Nov 26, 2022
@erikmd erikmd merged commit e55cf61 into ocaml-sf:master Nov 26, 2022
@erikmd erikmd deleted the ci-issue475 branch November 26, 2022 23:34
@github-actions github-actions bot mentioned this pull request Nov 26, 2022
Merged
erikmd added a commit to AltGr/learn-ocaml that referenced this pull request Dec 29, 2022
@erikmd
Merge branch 'master' of https://github.com/ocaml-sf/learn-ocaml into…
e060885 
… pr/481 (to-be-rebased)

* 'master' of https://github.com/ocaml-sf/learn-ocaml:
  fix(learnocaml_report.css): Display multiple spaces in code excerpts (ocaml-sf#503)
  ci(pin-artifacts.yml): Add build artifacts links within upstream commits status (ocaml-sf#501)
  deps(opam): Bump ssl (0.5.10 -> 0.5.12) (ocaml-sf#499)
  build(static-binaries): Fix building of static binaries on CI (ocaml-sf#497)
@proofbot proofbot mentioned this pull request Jan 7, 2023
Merged
@erikmd erikmd added this to the learn-ocaml 0.14.1 milestone Jan 7, 2023
@erikmd erikmd added the kind: infrastructure CI, build tools, development tools label Apr 12, 2023
@erikmd erikmd mentioned this pull request Apr 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erikmd erikmd

Labels
kind: enhancement Enhancement to an existing user-facing feature. kind: infrastructure CI, build tools, development tools
Projects
None yet
Milestone
learn-ocaml 0.14.1
Development

Successfully merging this pull request may close these issues.

Feature: Improve static-builds.yml on pull_request (Add link to artifacts)
1 participant
@erikmd