Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate changes to Document.constant_equal #71

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

OlivierNicole
Copy link
Collaborator

@OlivierNicole OlivierNicole commented Sep 9, 2024

This is part of the convergence work toward JSOO (see #57). It is based on #67 and #70; the feature is contained in the last two commits.

It integrates ocsigen/js_of_ocaml#1659 and adapts wasm_of_code to it.

compiler/lib/flow.ml Outdated Show resolved Hide resolved
@vouillon vouillon force-pushed the converge-jsoo-merge-07 branch 2 times, most recently from 9dc0a47 to 91d8286 Compare September 20, 2024 09:39
OlivierNicole and others added 3 commits September 20, 2024 14:56
…related bugs (#1659)

* Document non-trivial function Code.constant_equal

Co-authored-by: Jérome Vouillon <jerome.vouillon@gmail.com>

* Fix bugs related to constant equality

See #1659.

* More static evaluation of equalities in eval

* Statically evaluate caml_js_strict_equals too

* Compiler: small refactoring in eval

---------

Co-authored-by: Jérome Vouillon <jerome.vouillon@gmail.com>
Co-authored-by: Hugo Heuzard <hugo.heuzard@gmail.com>
@vouillon vouillon force-pushed the converge-jsoo-merge-07 branch from 91d8286 to 68bf91e Compare September 20, 2024 12:57
@OlivierNicole OlivierNicole marked this pull request as ready for review September 20, 2024 13:15
@vouillon vouillon merged commit cfc3028 into ocaml-wasm:main Sep 20, 2024
2 checks passed
@OlivierNicole OlivierNicole deleted the converge-jsoo-merge-07 branch September 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants