-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple fixes for of_string functions #78
Conversation
This is ready for review |
@antoinemine, would you have time to review this PR ? |
Does |
I think it does
I've done that |
OK. It seems good to me. |
Thanks |
There are still a couple of MR and issues we could look into before a release. |
I've opened #82 to track the new release and make sure we don't drop it by accident. |
Z.of_string
should accept string with a0_
prefix.Q.of_string
should not accept a sign after a dot (akaQ.of_string ".-0"
should fail)Q.of_string
should accept leading underscore after a dot, even if the integer part is empty (akaQ.of_string "._123"
should succeed)