Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target inference for stanzas rule in long form should not be allowed if dune lang < 2.0.0 #3748

Closed
voodoos opened this issue Aug 27, 2020 · 1 comment

Comments

@voodoos
Copy link
Collaborator

voodoos commented Aug 27, 2020

Reproduction:

  • A dune-project file with lang dune < 2.0.0
  • A dune file with a stanza rule in long form without explicit targets:
(rule
  (action (copy# some_file.ml.%s some_file.ml)))

(note that this is indeed the long form, short would be (rule (copy# some_file.ml.%s some_file.ml)))

Expected Behavior

Latest Dune should refuse to build the project because target inference for the long forms of the stanza rule was introduced in version 2.0.0 of the dune language (#2494, fixes #2469).

Actual Behavior

Latest Dune builds the project without complaining.

Specifications

  • Version of dune: 2.7.0 (but probably all versions >= 2.0.0 are affected)
  • Version of ocaml: 4.11.0
  • Operating system: MacOS Catalina

Other

See ocaml/merlin#1157

@emillon
Copy link
Collaborator

emillon commented Aug 31, 2020

Duplicate of #3230

@emillon emillon marked this as a duplicate of #3230 Aug 31, 2020
@voodoos voodoos closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants