Infer rule targets in long-form rule stanzas as well #2494

NathanReb · 2019-08-01T09:37:02Z

I added a couple tests for the rule target inferrence. There was one indeed but it wasn't testing the case from #2469.

I'm happy to add more tests to have better coverage of that feature and of course to provide a fix, as part of this PR or of a separate one, whichever works best for you!

NathanReb · 2019-08-01T09:43:12Z

It's also unclear what the proper fix is, i.e. whether it's to infer targets even when using (rule (action x)) instead of (rule x) or to improve the error message in such cases.

rgrinberg · 2019-08-01T09:46:59Z

Yes, we should infer targets in that case. Consider this form:

(rule
 (deps (:foo (glob_files *.foo))
 (action (with-stdout-to bar (run bla %{foo})))

It's clearly better that the bar target is inferred here rather than making the user go through variables.

NathanReb · 2019-08-01T09:48:25Z

Yeah that makes total sense! I'll do that!

aalekseyev · 2019-08-01T09:59:55Z

Thanks for the tests.

By the way, we generally have tests passing, even when they demonstrate undesirable behaviors. So when I assumed your test was passing I got a bit confused.

The test should demonstrate the current behavior and the good behavior should be described in a comment.

NathanReb · 2019-08-01T10:01:14Z

Ok! I'll fix the test so that it pass so we can merge this and fix it separately!

NathanReb · 2019-08-01T11:54:28Z

I pushed 2 new commits, one fixing the issue and one adding a test for the error case!

rgrinberg

This will need a change log entry as well. Let's put it under 2.0 for now. I'll probably put it in 1.12

test/blackbox-tests/test-cases/rule-target-inferrence/run.t

Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>

Fixes ocaml#2469 Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>

test/blackbox-tests/test-cases/misc/run.t

src/dune_lang/dune_lang.ml

aalekseyev · 2019-08-01T12:57:49Z

test/blackbox-tests/test-cases/rule-target-inferrence/run.t

+  File "dune", line 1, characters 0-34:
+  1 | (rule (action (echo "something")))
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  Error: Rule has no targets specified


@rgrinberg, FWIW, I don't think this is "cannot be inferred", this is "can be inferred to be empty", which is a different situation. If the intention is to make something opaque to dune, you do need an external command. (I'm not saying one test is more important or better than the other, just that they test different things)

Agreed. Did you mean to mention @NathanReb however? I'd also prefer a message like dune was not able to infer any targets and none were manually specified.

I meant to mention you because you suggested echo was an appropriate replacement for "bash". I don't think "none were manually specified" is useful in this situation because that's misleading: specifying targets won't help.

Yeah I added the test case to showcase that the error message could be improved. I'll add a different test for the no-target case and use bash in this one again.

I'll take a look at how to improve the error message here!

Ah I see. So indeed we should have 2 messages:

No targets were specified

Dune did not infer any targets

@NathanReb would you like to improve dune to distinguish between these?

@NathanReb there's still no need to use bash btw. Use system.

I added the test case but from a very quick look it seems like it's going to take a tiny bit more effort to distinguish those two error cases so feel free to merge as it if you need to.

I'll work on that separately!

Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>

This is required to make dependencies explicit as well, it is fixed in ocaml/dune#2494 but in the meantime we have to explicitly specify the target to use the long form.

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft1) CHANGES: - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb)

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft1) CHANGES: - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb)

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft1) CHANGES: - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb)

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft1) CHANGES: - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb)

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft2) CHANGES: - The `action` field in the `alias` stanza is not available starting `lang dune 2.0`. The `alias` field in the `rule` stanza is a replacement. (ocaml/dune#2846, fixes 2681, @rgrinberg) - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb) - Change the default `modes` field of executables to `(mode exe)`. If one wants to build a bytecode program, it now needs to be explicitly requested via `(modes byte exe)`. (ocaml/dune#2851, @diml) - Allow `ccomp_type` as a variable for evaluating `enabled_if`. (ocaml/dune#2855, @dra27, @rgrinberg) - Stricter validation of file names in `select`. The file names of conditional sources must match the prefix and the extension of the resultant filename. (ocaml/dune#2867, @rgrinberg) - Add flag `disable_dynamically_linked_foreign_archives` to the workspace file. If the flag is set to `true` then: (i) when installing libraries, we do not install dynamic foreign archives `dll*.so`; (ii) when building executables in the `byte` mode, we statically link in foreign archives into the runtime system; (iii) we do not generate any `dll*.so` rules. (ocaml/dune#2864, @snowleopard) - Reimplement the bootstrap procedure. The new procedure is faster and should no longer stack overflow (ocaml/dune#2854, @dra27, @diml)

@bschommer

…lugin, dune-private-libs and dune-glob (2.0.0) CHANGES: - Remove existing destination files in `install` before installing the new ones. (ocaml/dune#2885, fixes ocaml/dune#2883, @bschommer) - The `action` field in the `alias` stanza is not available starting `lang dune 2.0`. The `alias` field in the `rule` stanza is a replacement. (ocaml/dune#2846, fixes 2681, @rgrinberg) - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb) - Change the default `modes` field of executables to `(mode exe)`. If one wants to build a bytecode program, it now needs to be explicitly requested via `(modes byte exe)`. (ocaml/dune#2851, @diml) - Allow `ccomp_type` as a variable for evaluating `enabled_if`. (ocaml/dune#2855, @dra27, @rgrinberg) - Stricter validation of file names in `select`. The file names of conditional sources must match the prefix and the extension of the resultant filename. (ocaml/dune#2867, @rgrinberg) - Add flag `disable_dynamically_linked_foreign_archives` to the workspace file. If the flag is set to `true` then: (i) when installing libraries, we do not install dynamic foreign archives `dll*.so`; (ii) when building executables in the `byte` mode, we statically link in foreign archives into the runtime system; (iii) we do not generate any `dll*.so` rules. (ocaml/dune#2864, @snowleopard) - Reimplement the bootstrap procedure. The new procedure is faster and should no longer stack overflow (ocaml/dune#2854, @dra27, @diml) - Allow `.opam.template` files to be generated using rules (ocaml/dune#2866, @rgrinberg)

NathanReb requested review from rgrinberg and aalekseyev August 1, 2019 09:37

NathanReb force-pushed the inferred-rule-tests branch from 1a1fb5f to caf75e6 Compare August 1, 2019 09:37

NathanReb mentioned this pull request Aug 1, 2019

Add test cases for %{bin} and %{lib} in (deps ..) #2496

Merged

NathanReb force-pushed the inferred-rule-tests branch from caf75e6 to 160928f Compare August 1, 2019 10:04

NathanReb requested a review from a user August 1, 2019 11:41

NathanReb force-pushed the inferred-rule-tests branch from d053b43 to f081785 Compare August 1, 2019 11:53

NathanReb changed the title ~~Add tests for rule target inferrence~~ Infer rule targets in long-form rule stanzas as well Aug 1, 2019

rgrinberg requested changes Aug 1, 2019

View reviewed changes

test/blackbox-tests/test-cases/rule-target-inferrence/run.t Outdated Show resolved Hide resolved

NathanReb force-pushed the inferred-rule-tests branch from f081785 to 2039e2d Compare August 1, 2019 12:02

NathanReb added 3 commits August 1, 2019 14:05

Add basic tests for rule target inferrence

437e2ab

Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>

Remove existing inferred rule test in misc

29458b1

Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>

Make target or targets optional fields of rule stanzas

690714c

Fixes ocaml#2469 Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>

NathanReb force-pushed the inferred-rule-tests branch from 6fc4441 to dd0fb43 Compare August 1, 2019 12:05

rgrinberg reviewed Aug 1, 2019

View reviewed changes

test/blackbox-tests/test-cases/misc/run.t Show resolved Hide resolved

rgrinberg reviewed Aug 1, 2019

View reviewed changes

src/dune_lang/dune_lang.ml Show resolved Hide resolved

rgrinberg approved these changes Aug 1, 2019

View reviewed changes

aalekseyev reviewed Aug 1, 2019

View reviewed changes

aalekseyev approved these changes Aug 1, 2019

View reviewed changes

Add test-cases for rule inferrence error

04f60a4

Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>

NathanReb force-pushed the inferred-rule-tests branch from dd0fb43 to 04f60a4 Compare August 1, 2019 13:54

rgrinberg merged commit 92ed100 into ocaml:master Aug 2, 2019

NathanReb mentioned this pull request Aug 19, 2019

Initial end-to-end test suite mirage/alcotest#178

Merged

emillon mentioned this pull request Oct 17, 2019

Tests: do not use ocaml syntax in the dune file ocaml-ppx/ocamlformat#1082

Merged

rgrinberg mentioned this pull request Oct 31, 2019

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.0.0+draft1) ocaml/opam-repository#15157

Closed

rgrinberg mentioned this pull request Oct 31, 2019

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.0.0+draft1) ocaml/opam-repository#15158

Closed

rgrinberg mentioned this pull request Nov 12, 2019

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.0.0+draft2) ocaml/opam-repository#15261

Closed

rgrinberg mentioned this pull request Nov 20, 2019

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.0.0) ocaml/opam-repository#15334

Merged

emillon mentioned this pull request Mar 3, 2020

Long form target inference is not properly versioned #3230

Open

voodoos mentioned this pull request Aug 27, 2020

Target inference for stanzas rule in long form should not be allowed if dune lang < 2.0.0 #3748

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Infer rule targets in long-form rule stanzas as well #2494

Infer rule targets in long-form rule stanzas as well #2494

NathanReb commented Aug 1, 2019

NathanReb commented Aug 1, 2019

rgrinberg commented Aug 1, 2019

NathanReb commented Aug 1, 2019

aalekseyev commented Aug 1, 2019

NathanReb commented Aug 1, 2019

NathanReb commented Aug 1, 2019

rgrinberg left a comment •

edited

Loading

aalekseyev Aug 1, 2019

rgrinberg Aug 1, 2019

aalekseyev Aug 1, 2019 •

edited

Loading

NathanReb Aug 1, 2019

rgrinberg Aug 1, 2019

rgrinberg Aug 1, 2019

NathanReb Aug 1, 2019

Infer rule targets in long-form rule stanzas as well #2494

Infer rule targets in long-form rule stanzas as well #2494

Conversation

NathanReb commented Aug 1, 2019

NathanReb commented Aug 1, 2019

rgrinberg commented Aug 1, 2019

NathanReb commented Aug 1, 2019

aalekseyev commented Aug 1, 2019

NathanReb commented Aug 1, 2019

NathanReb commented Aug 1, 2019

rgrinberg left a comment • edited Loading

Choose a reason for hiding this comment

aalekseyev Aug 1, 2019

Choose a reason for hiding this comment

rgrinberg Aug 1, 2019

Choose a reason for hiding this comment

aalekseyev Aug 1, 2019 • edited Loading

Choose a reason for hiding this comment

NathanReb Aug 1, 2019

Choose a reason for hiding this comment

rgrinberg Aug 1, 2019

Choose a reason for hiding this comment

rgrinberg Aug 1, 2019

Choose a reason for hiding this comment

NathanReb Aug 1, 2019

Choose a reason for hiding this comment

rgrinberg left a comment •

edited

Loading

aalekseyev Aug 1, 2019 •

edited

Loading