-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the name of a few variables #842
Comments
We can also use the |
Indeed, it's the same kind of change |
@emillon which parts of this PR are you tackling? Btw, the listing of variables to be renamed is incomplete in this PR. Are you planning on tackling all the renames, or just those in this issue? |
I have no precise plans yet, but I was thinking about the path vs deps ones. Maybe we can close this and add bugs for individual items? That'll be easier to track & coordinate. |
Up to you. I can handle the renames that aren't mentioned in this ticket for now. |
OK, I'll take care of the ones mentioned in here then. |
- `${path:file}` -> `%{dep:file}` - `${path-no-dep:file}` -> `%{path:file}` See ocaml#842 Signed-off-by: Etienne Millon <etienne@cryptosense.com>
- `${path:file}` -> `%{dep:file}` - `${path-no-dep:file}` -> `%{path:file}` See ocaml#842 Signed-off-by: Etienne Millon <etienne@cryptosense.com>
- `${path:file}` -> `%{dep:file}` - `${path-no-dep:file}` -> `%{path:file}` See ocaml#842 Signed-off-by: Etienne Millon <etienne@cryptosense.com>
- `${path:file}` -> `%{dep:file}` - `${path-no-dep:file}` -> `%{path:file}` See ocaml#842 Signed-off-by: Etienne Millon <etienne@cryptosense.com>
See ocaml#842 Signed-off-by: Etienne Millon <etienne@cryptosense.com>
See ocaml#842 Signed-off-by: Etienne Millon <etienne@cryptosense.com>
This is done |
The names and casing of variables are not very consistent. I propose to use lowercase for all variables such as
OCAML
and additionally do the following renaming:%{path:file}
-->%{dep:file}
, I think this way it's clearer what it means%{path-no-dep:file}
-->%{path:file}
SCOPE_ROOT
-->project_root
%{findlib:...}
which is redundant with%{lib:...}
#576 adds a
dir_kind
in the code that tells us whether the directory contains ajbuild
ordune
file. We can use that to use the new names only indune
filesThe text was updated successfully, but these errors were encountered: