test: reproduce dune exec -w crash with pkg management

[anmonteiro]

reproduces the crash in #10959

[Alizter]

  let update_build_progress_exn ~f =

is initialising when this happens so I need to find who is updating the build progress this early.

[Alizter]

For some reason this stems from the let* binding of env in run_eagar_watch. Not sure how it is being triggered yet however.

[anmonteiro]

I just pushed a commit that delays evaluating Env.t Memo.t until get_path_and_build_if_necessary

[anmonteiro]

before addressing the outstanding code review items, I'd like some confirmation that the fix is in the right direction, or even correct.

[rgrinberg]

The fix looks good to me

[anmonteiro]

should be ready for another look

[rgrinberg]

A bit worried about this test being flaky. I suppose we can disable if it proves to be a problem.

[anmonteiro]

Absolutely. In my tests it was always under the allocated time budget so we can disable it if it regresses.

[maiste]

before addressing the outstanding code review items, I'd like some confirmation that the fix is in the right direction, or even correct.

Does this PR also fix the problem, or is it the test to find the problem?

[anmonteiro]

this PR should also have fixed the issue. is it still reproducible for you?

[maiste]

Sorry, it was a misunderstanding on my side with the title of the PR. I tried it and it definitely fixes the problem, thanks 🙏