Always display the line number in file excerpts #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuragsoni
reviewed
Aug 31, 2018
src/errors.ml
Outdated
| @@ -59,6 +59,9 @@ let file_lines path ~start ~stop = | |||
| aux [] 1 | |||
| ) | |||
|
|
|||
| let pp_line padding_width pp (lnum, l) = | |||
| Format.fprintf pp "%*s: %s\n" padding_width lnum l | |||
There was a problem hiding this comment.
do we want to use | instead of : here? Or is it okay to switch that as part of #1168 ?
There was a problem hiding this comment.
that can be done on the other PR, this keeps the diff small on this side.
ghost
approved these changes
Aug 31, 2018
Signed-off-by: Etienne Millon <me@emillon.org>
emillon
force-pushed
the
always-display-file-number
branch
from
ce1dd32
to
46338d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1196 (comment), we can be more consistent when printing these messages.
cc @anuragsoni