Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix separate installation of implementations #2361

Closed
wants to merge 3 commits into from
Closed

Fix separate installation of implementations #2361

wants to merge 3 commits into from

Commits on Jul 8, 2019

  1. Fix separate installation of implementations 

    When instantiating an implementation with a variant, make sure it matches vlib's
known implementations. It replaces the same-project check that was done when
instantiating an implementation.

Signed-off-by: Lucas Pluvinage <lucas.pluvinage@gmail.com>
    @TheLortex
    TheLortex committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    9b8561e View commit details
    Browse the repository at this point in the history

  2. Use only the error monad 

    Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
    @rgrinberg @TheLortex
    rgrinberg authored and TheLortex committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    44b9ecc View commit details
    Browse the repository at this point in the history

  3. add a more specific error and a corresponding test. 

    Signed-off-by: Lucas Pluvinage <lucas.pluvinage@gmail.com>
    @TheLortex
    TheLortex committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    8fafd1a View commit details
    Browse the repository at this point in the history