Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce interleaving in the scheduler #586

Merged
1 commit merged into from Mar 5, 2018
Merged

Reduce interleaving in the scheduler #586

1 commit merged into from Mar 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 5, 2018

This should help with #581

@ghost ghost requested review from rgrinberg and dra27 March 5, 2018 11:57
@ghost
Copy link
Author

ghost commented Mar 5, 2018

If you look at the tests, things look indeed a bit more "grouped"

Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could all this extra bit of waiting cause a performance regression? I'd imagine it would be minimal as scheduling isn't the bottleneck here. But would be interesting to know.

@ghost
Copy link
Author

ghost commented Mar 5, 2018

Yes, it could if the code in Jbuilder itself is slow. I just checked with building jenga from scratch with -j1 and -j20 between master and this PR and I observed no differences.

@ghost ghost merged commit 4857ed4 into ocaml:master Mar 5, 2018
ghost pushed a commit that referenced this pull request Mar 14, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant